Bug: hasStartedFv not correctly removed after fv success

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.

good-dapp.vercel.app

MIT License

101 stars 52 forks source link

Bug: hasStartedFv not correctly removed after fv success #4188

Closed L03TJ3 closed 3 months ago

L03TJ3 commented 6 months ago

Description

There is a localstorage item added called 'hasStartedFv' to keep track of users completing/not completing FV.

After completing FV succesfully this item should be removed so that the fv survey does not get triggered. currently, this seems to not be deleted as expected.

Bug: users after succesfully completing face-verification get the 'why didn't you complete FV' modal pop-up on their dashboard

[x] - should only keep hasStartedFv when not succesfull

L03TJ3 commented 5 months ago

@patpedrosa @decentralauren Could you give your opinion on priority for this one?

It is a bit weird and bad ux for new users just starting up their gooddollar wallet

decentralauren commented 5 months ago

@L03TJ3 do we know how many users this is affecting? cc @vldkhh

L03TJ3 commented 5 months ago

I reported this myself because I had to re-verify after deleting my faceID.

To me it seems this could potentially affect any one who signs up?

@vldkhh can you confirm this on dev? In fv, navigate back once and then complete succesfully Then also, just do fv in one succesfull flow

vldkhh commented 3 months ago

verified on dev

decentralauren commented 3 months ago

@L03TJ3 any reason we haven't deployed this?

L03TJ3 commented 3 months ago

@decentralauren because of bugs that blocked us releasing

vldkhh commented 3 months ago

verified on qa

vldkhh commented 3 months ago

verified on prod