search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Event "NOTIFICATION_TAPPED" triggered automatically. #4205

Closed drptiago closed 9 months ago

drptiago commented 10 months ago

Description

The event NOTIFICATION_TAPPED happens when a user interact with a notification we sent NOTIFICATION_SENT

But checking the events, the NOTIFICATION_TAPPED is happening in the same second of NOTIFICATION_SENT, so it seems to be automatic.

We need to trigger this NOTIFICATION_TAPPED only when the user clicks on the notification.

Steps to reproduce

Check this user: https://app.amplitude.com/analytics/gooddollar/project/288710/search/amplitude_id%3D190777824400?collapsed=true&sessionHandle=Y0xEJ0%2F_Y0xELne_CxrPpSQ_BGfG_dc952a0c-a042-4e71-808f-a5133b089cabR&eventId=f2f95056-4f78-4ede-a54b-8b496fef67ff

This behavior is the same in different users, in the same second the NOTIFICATION_SENT happens the NOTIFICATION_TAPPED also happens.

L03TJ3 commented 10 months ago

@drptiago you say same behavior for different users. Is it he same behavior for all users tho?

drptiago commented 10 months ago

Yes @L03TJ3 all users with NOTIFICATION_TAPPED event have this behavior.

In this dashboard, click in the line and user streams, you will see this is the behavior to all of them. https://app.amplitude.com/analytics/gooddollar/chart/smeoke9?linkingDashboardId=thkrruw

L03TJ3 commented 9 months ago

Has been resolved as it was the NOTIFICATION_EVENT which was triggered when opening the app when someone tapped the notification: https://github.com/GoodDollar/GoodDAPP/commit/e57874a5b95bcb2a17f2fed6df4ecefe8509f531

L03TJ3 commented 9 months ago

@drptiago to what extend can this be considered solved?

drptiago commented 9 months ago

Fixed.

It's clear now the NOTIFICATION_SENT cannot be tracked, we can only track NOTIFICATION_TAPPED