Add: make full-name visibility configurable

[L03TJ3]

Business Description

User should be able to determine whether their full name, first name only or no name displays in wallet transactions. This should be configured in the Settings.

More Detail

• [ ] Easier to implement for all transactions moving forward or all transactions (past and future)?

Acceptance Criteria

User can change preferences to display full name... User can change perferences to display first name only... User can change preferences to not display name at all, and only their wallet address will show in transactions

[decentralauren]

@L03TJ3 - which is easier to implement:

• User makes a change and that change takes effect for all future transactions
• User makes a change and that change takes effect for all transactions, past, present and future?

[L03TJ3]

@decentralauren I think what we get by default is: User makes a change and that change takes effect for all transactions, past, present and future?

Based on changes done to contract names for example which also iterated back over past transactions @johnsmith-gooddollar @sirpy for confirmation on this

[L03TJ3]

@johnsmith-gooddollar @sirpy based on acceptance criteria. is it easy to change the db to handle the 'first name only' scenario? the other two is what we have now (when set to private > full name is not saved to database display value

[sirpy]

@L03TJ3 no, for all I recall the name is fetched only once for new txs. so the name will not update for older txs. it probably is also better this way, less confusing for the parties invovled. you did a TX with Y and suddently you cant find it because he renamed to X.

[L03TJ3]

@sirpy Yes okay you are right, once it set it does not check and update again.

@decentralauren so we go for it will be affecting any future transactions. It will be immediate for third parties who request to use full-name, but we cannot control if 3rd parties cache it themselves ofcourse.

[decentralauren]

@L03TJ3 @sirpy thank you both! This is great.

Are we able to set the default here for new wallets or should I create a separate ticket for that?

[sirpy]

@decentralauren what do you mean? the default is public, if we enable to change, then the user should do it via the wallet privacy settings. but since the plan is to move to goodwalletv2, which doesn't currently have profiles, i'm not sure the effort is justified.