GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.

good-dapp.vercel.app

MIT License

101 stars 52 forks source link

Vite/Node18: Walletconnect fixes #4217

Closed L03TJ3 closed 5 months ago

L03TJ3 commented 5 months ago

Description

Wallet connect page breaks because of using methods before initalization.

[ ] - Removed some dependencies for the connect callback because this would require changing the order more and not sure this would be possible. review needed if they are indeed unnecessary (since the activeConnector will be updated based on those callbacks anyway)
[x] - fix initialization order

How has it been tested

Locally, verified working page + connection to gooddapp.org

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
goodwallet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2024 5:36am

2 Ignored Deployments

L03TJ3 commented 5 months ago

@johnsmith-gooddollar @sirpy there are some unknown errors coming from https://verify.walletconnect.com/attestation/ when connecting but does not look like it breaks anything after that which I can see or test. also above error is already happening and not related to this fix

sirpy commented 5 months ago

commited fix