GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Update balance labels in GoodWallet #4240

Closed decentralauren closed 7 months ago

decentralauren commented 8 months ago

Business Description

GoodWallet users are confused by the current network labels under their GoodDollar balance, thinking that their balance refers to the amount of the network token they have ($CELO or $FUSE) rather than GoodDollars they have on the respective network.

We are updating the labels on each to "G$ Celo" and "G$ Fuse" respectively to clear up this confusion.

Detailed Description of Functionality

Screenshot 2024-03-18 at 9.10.14 AM.png

Figma file

Technical Implementation

*Outline the technical approach for building the feature. This section is typically filled out by the development team or can contain suggestions. (dev team: @johnsmith-gooddollar @sirpy @L03TJ3)

Acceptance Criteria

decentralauren commented 8 months ago

@L03TJ3 let me know any intel you find on when we changed this / why

decentralauren commented 8 months ago

OK we will proceed with this as designed! Including your research on past changes here for future reference:

The only two messages I can find related to https://github.com/GoodDollar/GoodDAPP/issues/4240 are these: https://t.me/c/1798594185/6436 <-- this is a bit confusing as it should already have shown: G$ https://t.me/c/1798594185/6542 <-- this is the last message I could find. I do remember it was asked about more, could be in the ambassadors channel or something I don't know what drove the change. all I know is I pushed the update to move it from this --

L03TJ3 commented 8 months ago

fixed here: https://github.com/GoodDollar/GoodDAPP/commit/696c097243a93890a90d6650b457cd47ee3c2161

vldkhh commented 8 months ago

verified on dev

vldkhh commented 8 months ago

verified on QA

decentralauren commented 8 months ago

@vldkhh @L03TJ3 I don't see this in the wallet - when do you plan to release?

L03TJ3 commented 8 months ago

@decentralauren we are blocked from releasing because of bugs. current discussion happening wallet-team channel

vldkhh commented 7 months ago

verified on prod