GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Send to Address - Error reduction improvements #4245

Open decentralauren opened 8 months ago

decentralauren commented 8 months ago

Business Description

The mods are getting a lot of complaints of people who are using the "Send to" feature and then are sending their tokens in the wrong way, losing them, and getting upset. Basically, people don't know how blockchain interoperability works, so they send tokens to another EVM addresses (or non evm addresses), and don't bridge. The result is that they lose the tokens, and are burned.

This epic includes a number of enhancements to the GW1 to help reduce the number of Send To transactions originated to unsupported or incorrect addresses.

Original Slack Discussion

Detailed Description of Functionality

There are 2 key parts of this improvement:

  1. Introducing better field error handling in the "Send to Address" field to disallow users from sending to detectable non-compliant addresses
  2. Introducing an interstitial modal after entering the address but before confirming the transaction, which urges the user to confirm that the address they are sending to is capable of receiving the funds.

Both will provide the user access to information about blockchain networks and the relationships between tokens and networks.

Technical Implementation

*Outline the technical approach for building the feature. This section is typically filled out by the development team or can contain suggestions. (dev team: @johnsmith-gooddollar @sirpy @L03TJ3)

Acceptance Criteria

sirpy commented 8 months ago

@decentralauren We didnt get any complaints when we were using the payment links. wouldnt it be smarter to make links the default and send to address some hidden advanced mode? What would happen on V2?

decentralauren commented 8 months ago

@sirpy V2 only has Send to Address (not links). And this feature is now used by the majority of GW1 users. GW2 already has some basic field-level validation however the error states are poor and need improvement.

sirpy commented 8 months ago

First this issue needs better definition of what exactly is the solution, because I don't see any solution besides maybe a popup with message "verify that the recipient is on network X." For gw1 maybe default to payment links is the better solution. How many complaints do we have? what exactly is the nature of the complaints? is it fuse/celo mixup? other blockchains?

decentralauren commented 8 months ago

@sirpy as outlined in the ticket, there are 2 solutions outlined above in "Detailed Description of Functionality ":

  1. a modal with a message (as you described) which will be in this ticket
  2. field error handling which will be in this ticket

Please note that this ticket is in the "Design & Requirements" pipeline, meaning it is still being refined and requirements are not complete, therefore is not yet ready for technical review or prioritized for dev.