GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Bug: 24h notice blocks re-doing FV #4266

Closed L03TJ3 closed 6 months ago

L03TJ3 commented 6 months ago

Description

After you delete your wallet/face-id and are trying to redo face-verification with the same wallet the notice 'you have to wait 24h' shows. This shows even after a few days and it blocks a user from doing the face-verification. Other bug noticed is that when visiting face-verification through gooddapp this notice shows and it immediately triggers a redirect back to gooddapp (no time to even read the notice)

Steps to reproduce

  1. delete your face-id
  2. wait 48h
  3. go to the face-verification flow
  4. the modal still shows *5. when coming from gooddapp the redirect back automatically happens

Expected

Which network did you use?

Supporting data

L03TJ3 commented 6 months ago

A backend fix is applied for incorrectly showing the 24h notice modal here: https://github.com/GoodDollar/GoodServer/commit/7fe0807534a5670b77f19c6dd4d861cad678f09e

A wallet fix is applied for the immediate redirect here: https://github.com/GoodDollar/GoodDAPP/commit/11ad7d8ae23913b75fc4a762c7e647080d8aff93

L03TJ3 commented 6 months ago

Confirmed that it works