GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

[Bug/Android,MobileWeb]: Wallet-connect #4267

Closed L03TJ3 closed 1 month ago

L03TJ3 commented 6 months ago

Description

There seems to several issues when using wallet-connect on mobile. (web works fine)

  1. Copy/Paste from gooddapp > android app: does not work, does not trigger connect modal
  2. Copy/Paste from gooddapp > mobile-web: does not work, does not trigger connect modal
  3. Scanning qr-code with android app: It vibrates the phone that it 'detects' something, does not trigger connect modal
  4. scanning qr code from mobile-web wallet: It does not detect anything, the camera seems to be blurry and never focus

Steps to reproduce

  1. Go to gooddapp (or other dapp, happens also with uniswap) (both mobile/desktop, does not really matter for this)
  2. Open the wallet on mobile (Either android app / mobile web, dependening on what you test from above)
  3. copy and paste a qr code, or scan qr code
  4. see that it does not show you a connect to dapp modal

Which network did you use?

Celo,Fuse

Supporting data

Android-app version: 2.38.1 (Latest) Android-version: 13 Phone: Samsung Browser: Chrome,Brave

L03TJ3 commented 6 months ago

@vldkhh could you test above and provide logs for the different scenario's maybe also a test an older version of prod to see if it was a recent release that broke it

L03TJ3 commented 6 months ago

fixed here: https://github.com/GoodDollar/GoodDAPP/commit/41ed7ece84ecf891bfe37e532f092c0e02ea5ad8

L03TJ3 commented 6 months ago

@vldkhh Can you retest wallet-connect connecting to any dapp (gooddapp/uniswap)

Also try to interact with it. For example, do a swap from celo > G$ on gooddapp

L03TJ3 commented 6 months ago
image.png