search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Bug-android: Walletconnect incoming tx request on FUSE #4299

Closed L03TJ3 closed 2 months ago

L03TJ3 commented 2 months ago

Description

There is an issue with receiving incoming wallet-connect requests. When sending a transaction from gooddapp we enforce 11e9 gasPrice.

The params/request/event coming in or parsed in the wallet is at 10e9, which results in a feeToLow error.

We also enforce a 11e9 gasprice on the wallet-side by overriding message.gasPrice. The bug is more that in none of the events/params request for sending a tx it takes any value set from gooddapp.

To reproduce:

  1. go to gooddapp and connect wallet through wallet-connect
  2. claim GOOD rewards (or just do UBI claim)
  3. Result: feeToLow error shows in modal on wallet -- crashes the app on android > actual transaction succeeds

Additional notes:

  1. seems to be a wallet issue. when I tested wallet-v2 with a wallet-connect connection, it receives the set 11e9 price correct (Awaiting confirmation on this). the reason why I put the bug here, not on gooddapp. other test is that when connecting metamask, it receives the set gasPrice correctly as well
  2. on web, everything worked without issues

Which network did you use?

Fuse

L03TJ3 commented 2 months ago

fixed