search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

[BUG, GoodID, Brave] The GoodID flow doesn't work properly using Brave Browser #4324

Closed vldkhh closed 3 weeks ago

vldkhh commented 1 month ago

[BUG, GoodID, Brave] The GoodID flow doesn't work properly using Brave Browser

Geolocation API doesn't work using Brave Browser on macOS:

@decentralauren What information we need to provide to users? Not to use Brave Browser? Please provide detailed information what we need to do with this.

@L03TJ3 @sirpy Provide more information about this bug please, because I don't understand what the issue is

Proposed fix:

  1. Whenever a unknown or silent error happens when going through the segmentation flow it should not block a user from continuing the flow.
decentralauren commented 1 month ago

@vldkhh can you please link to the slack thread with the recording and issue description?

sirpy commented 3 weeks ago

@vldkhh When using MACOS with Brave it got stuck in the goodid flow where it fetches your information after you approve using the location.

@L03TJ3 This seems to be fixed in the latest brave where it does throw an exception and doesn't get stuck.

but still it is not able to get the geolocation if your wifi is not turned on