GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
107 stars 55 forks source link

User should get a magic link on signup instead of recovery #493

Closed sirpy closed 5 years ago

sirpy commented 5 years ago

Instead of sending the recovery seed phrase We send a link with the user's gundb username+password ie dapp.gooddollar.org?magiclink=username+pass encoded

username and password already generated from a seed phrase in this par of code: https://github.com/GoodDollar/GoodDAPP/blob/ed432880af9b3918acc7d8475025a23005f44a51/src/lib/gundb/UserStorageClass.js#L327-L328

Flow

Definition of Done

sirpy commented 5 years ago

@AnastasiiaOdnoshevna this can only be tested on goodqa env since emails are not sent on gooddev

sirpy commented 5 years ago

@AnastasiiaOdnoshevna this should be testable no goodqa now, though we still didnt modify the email template

qatests1001 commented 5 years ago

Checked on https://goodqa.netlify.com/ There is a bug https://www.screencast.com/t/6cM0Ne3y6

sirpy commented 5 years ago

@qatests1001 you are trying to use with an invalid w3 token.