GoodDollar / GoodIdentity

A decentralized organization that handles Identity verification to its members.
2 stars 0 forks source link

Candidate Selector full scroll support #7

Open hadarbmdev opened 5 years ago

hadarbmdev commented 5 years ago

Make CandidateSelector display a single candidate at a time (no matter what is the screen size) and onScroll, when a single candidate is shown on the screen, update the state.selectedCandidate to the current displayed candidate.

Currently the logic is half implemented, the following bugs occur (need to be fixed as part of the issue):

  1. Screen shows all photos together and not a single photo that is scrollable to the next photo (or back)

  2. The following message appear: You specified onScroll on a but not scrollEventThrottle. You will only receive one event. Using 16 you get all the events but be aware that it may cause frame drops, use a bigger number if you don't need as much precision.

  3. The following bug appear when trying to scroll on mobile view (which is the only display that enables scrolling) Uncaught TypeError: Cannot read property 'props' of undefined at Object.onScroll (CandidateSelector.js:61)