GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

MicroBridge should work with the new SuperGoodDollar #289

Open sirpy opened 1 year ago

sirpy commented 1 year ago

The updated bridge will now work with the new "SuperGoodDollars" on Celo that are 18 decimals

L03TJ3 commented 1 year ago

This can be verified and tested on fi-dev as we speak (going over it myself in a few)

sirpy commented 1 year ago

@L03TJ3 yes but you need to upgrade to the latest bridge sdks

L03TJ3 commented 1 year ago

yes, just seeing that point!

L03TJ3 commented 1 year ago

General support for 18 decimals, and bridge specific support is now split into two parts. Protocol part has been moved to: https://github.com/GoodDollar/GoodProtocolUI/issues/293

johnsmith-gooddollar commented 1 year ago

@L03TJ3 please tell @vldkhh how to test it also describe the bug you found - it should be tested firstly

decentralauren commented 3 months ago

@vldkhh - moved this back to QA for you to test but please hold until Lewis and I review any other potential bugs so you can test at once when ready.

L03TJ3 commented 2 months ago

Confirmed that on celo the conversion is not done correctly, moving back to new issues

decentralauren commented 1 month ago

@L03TJ3 is this still relevant? If so I'll move to product backlog as it seems important / relevant to the MB release.

L03TJ3 commented 1 month ago

@decentralauren yes still relevant. part of the current existing bugs