GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Switch to vite for faster builds #414

Closed sirpy closed 1 year ago

sirpy commented 1 year ago

Description

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-swap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 3:23pm
johnsmith-gooddollar commented 1 year ago

@sirpy @L03TJ3

  1. need to resolve conflicts
  2. when it could be merged ?
L03TJ3 commented 1 year ago

@sirpy @johnsmith-gooddollar Please re-review, latest 2 commits come with the following changes:

  1. upgraded tailwind/postcss since it was still relying on a specific CRA compatibility package for postcss (works fine, and verified working on vercel deployment + local

  2. I upgraded typescript to 5>. This was done while I was figuring out a tsc compile type error (preventing commit). In the end, the upgrade would not be necessary since the actual fix was just a more declarative type definition needed in the useActiveOnboard hook. But I also have not encountered any new issues besides a few extra type definitions around the tailwind theme object.

I don't see any issues in keeping the upgrade, but maybe one of you has an objection as to why we would not upgrade now If that's the case, ill revert typescript. No objection? then it could be merged after a review

sirpy commented 1 year ago

@johnsmith-gooddollar please revert linguifix changes. unless you point to a bug, I only see unrequired refactoring which wasnt first approved by me.

@L03TJ3 @johnsmith-gooddollar please revert the russian removal. G$ is not political and is not taking any sides besides the side of the people, helping all people of the world. Not all russians are brainwashed and not all russian speaking people live in russia or are russians.

johnsmith-gooddollar commented 1 year ago

@L03TJ3 @johnsmith-gooddollar please revert the russian removal. G$ is not political and is not taking any sides besides the side of the people, helping all people of the world. Not all russians are brainwashed and not all russian speaking people live in russia or are russians.

This isn't politics anymore. Do you read news ? They just exploded Kahovka water reservoir. A lot of square kilometres of land, cities and the villages will be flooded. Also, changing of the water level may cause disaster at Zaporizhzhia nuclear plant (a similar way it was at Fukushima). We could receive the second one Tchernobyl !

Almost all russians are brain washed. Any russian "democracy" or "liberalism" ends when the Ukrainian sovereignty arises.

Russians won't accept Ukraine as an independent state. Never. The same way like Palestina and arabic countries nearby won't accept independency of Israel and will time by time start wars and perform terroristic attacks.

But all we know that Crimea is Ukraine and Jerusalem is a true capital of Israel. You know which side is right. So let's support the truth and justice in this question

johnsmith-gooddollar commented 1 year ago

@johnsmith-gooddollar please revert linguifix changes. unless you point to a bug, I only see unrequired refactoring which wasnt first approved by me.

You uses a lot of XXXSync fns, I've just changes to async ones, promisified (sync functions should be used in node only if no other way) also performed some cleanup from things not used anymore and some reformatting as it was hard for me to understand the original code

sirpy commented 1 year ago

@johnsmith-gooddollar please revert linguifix changes. unless you point to a bug, I only see unrequired refactoring which wasnt first approved by me.

You uses a lot of XXXSync fns, I've just changes to async ones, promisified (sync functions should be used in node only if no other way) also performed some cleanup from things not used anymore and some reformatting as it was hard for me to understand the original code

as i've requested countless times, no refactoring unless I aprove it first

johnsmith-gooddollar commented 1 year ago

@johnsmith-gooddollar please revert linguifix changes. unless you point to a bug, I only see unrequired refactoring which wasnt first approved by me.

You uses a lot of XXXSync fns, I've just changes to async ones, promisified (sync functions should be used in node only if no other way) also performed some cleanup from things not used anymore and some reformatting as it was hard for me to understand the original code

as i've requested countless times, no refactoring unless I aprove it first

it just a small utility and it was needed at least code cleanup & reformatting, as initially was totally non-understandable for me

L03TJ3 commented 1 year ago

@johnsmith-gooddollar @sirpy Is the linguifix good now? or should the commit still be reverted if we can agree on current lingui-fix this pr can be merged