create a global "please sign tx in your wallet" modal

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts

https://good-swap.vercel.app

GNU General Public License v3.0

7 stars 12 forks source link

create a global "please sign tx in your wallet" modal #417

Open sirpy opened 1 year ago

sirpy commented 1 year ago

based on usedapp notifications
when a tx is in the waiting for sig state show a modal
once a tx is in pending state you can then trigger the toast for txs

L03TJ3 commented 6 months ago

@decentralauren not sure what to do with this or how to give it a 'priority-level'. This is about what was discussed for user-feedback on gooddapp (including toasts). and a more general implementation of transaction modals.

this only relates to anything that has been build since celo-launch (claim flow / buy-gd / microbridge)
nothing from any old(er) features can benefit from this
currently we only have the claim-flow live and already has a sign-tx modal in the flow

decentralauren commented 6 months ago

@L03TJ3 OK so the only benefit to implementing toasts now is for the claim flow to have a pending confirmation after the transaction is signed? Doesn't seem useful at this time, though adding toasts in the future may be appropriate.