search

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Add bubbles while overing on all titles of the portfolio #42

Closed tomerGD closed 2 years ago

tomerGD commented 3 years ago
tomerGD commented 3 years ago

While hovering over the titles of the table in the portfolio should add "additional data" bubbles as other titles have.

mukulshakya commented 3 years ago

Hey @tomerGD

can you share a design mockup for the task?

sirpy commented 3 years ago

@mukulshakya @MayurAdaptiveCode here's the figma link to the current design you can see the tooltip in multiple places. there should be a ? or i icon next to the title and on hover it show show the tooltip. @tomerGD we need a ?/i icon? or just show tooltip on title hover?

example form the design image.png

mukulshakya commented 3 years ago

Thank you @sirpy

Hi @sirpy @tomerGD This is the current design of the portfolio page and ? is placed in some places also. Where additionally is it needs to be added?

image.png

tomerGD commented 3 years ago

@mukulshakya use exactly the same deisgn as TOKEN and PROTOCOL has, please ad it to TYPE, STAKE, G$ REWARDS, MULTIPLIER, GDAO REWARDS

sirpy commented 3 years ago

@mukulshakya I suggest that we do dynamic if the text translation key for the title is non empty then show the ? icon. ie if(iln8('token_explanation')!="")

mukulshakya commented 3 years ago

Hey @tomerGD @sirpy

Can i get the all the messages that we need to show on the bubble.

mukulshakya commented 2 years ago

PR - https://github.com/GoodDollar/GoodProtocolUI/pull/58

mukulshakya commented 2 years ago

Hey @tomerGD @sirpy

Bubble have been added to the portfolio table we just need text description for each one

image.png

codecapo commented 2 years ago

@tomerGD

Can you provide the text description for the bubbles please, thanks.

sirpy commented 2 years ago

@adaptivecodeio there's an with a document with the texts

mukulshakya commented 2 years ago

I found the doc but the texts are not present for the required headers.

sirpy commented 2 years ago

@sepu85 Hey Gus, can you take this over?

sepu85 commented 2 years ago

@mukulshakya sorry for the delay in this, here the input you are requesting: