GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Bug: (wc2) Sending transactions on celo do not contain appropriate tx details #424

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Bug Description Not all details are provided in the payload for tx handling (when using wallet-connect / onboard / gooddollar-wallet) As seen in screen (an approve tx) has value 0, so you give permission for 0 G$ to be spend

Need to determine if this is wallet-connect or ubeswap component issue

Steps to Reproduce

  1. Go to gooddapp
  2. connect gooddollar wallet, and try to swap (celo/ubeswap)
  3. see the transaction detail modal popping up in wallet

Expected Behavior Values should be properly set and send as payload. Approval should be done for the amount trying to be swapped.

Additional Context image

L03TJ3 commented 1 year ago

Forwarded some questions to the ubeswap team as there likely are now issues because of the use of wc2

Was unable to verify this against v1 as the invalid-topic issue still roams around. Also using ubeswap directly with wallet-connect has issues.

So awaiting feedback

sirpy commented 1 year ago

@L03TJ3 this is not a bug, "value" is for sending native tokens with the TX. The specific function call and its data are encoded in the "data" field you can try to be the data here and see it decoded: https://www.moesif.com/solidity-abi-hex-decoder/decode