GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Bug: metamask mobile and wallet-connect v2 #443

Closed L03TJ3 closed 10 months ago

L03TJ3 commented 1 year ago

Bug Description Its not an issue on our side, but this issue is created for the task of testing/bumping onboard packages to latest versions when all is fixed

Metamask mobile has known issues when trying to connect with gooddapp (any dapp) Current status

  1. it has to have the same network selected in both wallet/dapp
  2. switching from dapp breaks the flow/connection
  3. switching from the wallet works

onboard thread: https://github.com/blocknative/web3-onboard/issues/1783 Metamask threads:

  1. https://github.com/MetaMask/metamask-mobile/issues/6655
vldkhh commented 12 months ago

@L03TJ3 I see that sometimes the claim is working just fine (tx appears in MM), sometimes it does not appear at all, and sometimes I got JSON RPC error on the fuse chain. Take a look: https://gooddollar.slack.com/files/U03L9737V08/F05GY43QC66/rpreplay_final1689268307.mp4

L03TJ3 commented 11 months ago

it appears the onboard packages where not synced correctly so I am not sure which version we were actually using I now bumped to latest versions. Switching from dapp side seems to be a continuous issue, but the rest should work better

@vldkhh will merge in a bit to QA, if you can re-test metamask there

vldkhh commented 10 months ago

see no issues with MM on prod