GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Simple-app #454

Closed sirpy closed 10 months ago

sirpy commented 11 months ago

Add a simple app mode when visiting ?simpleapp=true It will not show any wallet connect option and will try to auto connect to the injected wallet. in swap mode it will automatically set the target swap to cUSD

TODO:

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-swap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2023 6:47pm
sirpy commented 11 months ago

@patpedrosa See the screen in the description. Needs to make it look good. plus i believe the blue box is not clear enough that it's a call to action to click on it

L03TJ3 commented 11 months ago

@sirpy The space at the top is because we center the uniswap-widget. if we don't do this there will be a huge gap at the bottom (for larger-height screens) this because the bottom-bar is fixed to the bottom of screen

Ofcourse this we could change but then we have to refactor the structure since the bottom-bar on mobile is hacked to the bottom (where it actually is inside the top-bar div)

sirpy commented 10 months ago

@L03TJ3 ok so we should fix it, either try to find a universal way to center it with/without bottom bar or customize center for the state (isSimpleApp) when no bottom bar

sirpy commented 10 months ago

@L03TJ3 @patpedrosa i've opened the issue #455 for this