GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Chore: update onboard packages for latest wc fixes #469

Closed L03TJ3 closed 7 months ago

L03TJ3 commented 9 months ago

Bug Description This got fixed: https://github.com/blocknative/web3-onboard/issues/1783#issuecomment-1743761627

L03TJ3 commented 9 months ago

fixed here: https://github.com/GoodDollar/GoodProtocolUI/commit/05dbb777d6420fab32fd14786b48e5bbd8ebf2dc

Fix is that metamask mobile when not being on the same chain as dapp now requests to switch (in-app) before showing tx request

kr-keshav-kk commented 8 months ago

@L03TJ3 when can we expect this bug to be fixed?

L03TJ3 commented 8 months ago

@kr-keshav-kk is live already

image

if you request a transaction from gooddapp that is from a different chain then your metamask, above modal should show up to first switch > then confirm transaction

you experience something different?

kr-keshav-kk commented 8 months ago

I follwed this issue and came here. Mobile MM is not showing any pop up when network switch is triggered from my webapp. Do you have any solution? I am using svelte.

sirpy commented 8 months ago

@kr-keshav-kk i believe network switching on wallet in case of walletconnect is not required. your dapp is supposed to put in the initial connection props the requirednetworks and optional networks. when you send a tx it is supposed to include the target chainid and the wallet then knows on which network to execute it

L03TJ3 commented 8 months ago

@kr-keshav-kk MM pops up a switch modal only when trying to send a transaction for a different chain then is currently selected in the users wallet.

the switching itself is not an event anymore which does this as @sirpy says: a dapp/wallet now sets required/optional chains that are supported by either wallet/dapp

kr-keshav-kk commented 8 months ago

@L03TJ3 @sirpy is there any way i can call the network change pop up just after connecting MM? I am using MM to sign a message and then send a transaction.

L03TJ3 commented 8 months ago

you could look at: https://usedapp-docs.netlify.app/docs/guides/transactions/switching%20networks/ which is what we used before.

but I don't think that is relevant and metamask automatically does the switch chain when the request is from another chain

vldkhh commented 7 months ago

verified on prod