[Design QA] Side menu (desktop)

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts

https://good-swap.vercel.app

GNU General Public License v3.0

7 stars 12 forks source link

[Design QA] Side menu (desktop) #473

Closed SanaJamm closed 8 months ago

SanaJamm commented 8 months ago

Issue 1

[ ] Let the side menu extend to the bottom of the screen always:

Issue 2:

[ ] Privacy policy and T&C should stick to the bottom of the side menu with 16px padding from the bottom

Devs:

Design:

vldkhh commented 8 months ago

waiting for confirmation from Sana

SanaJamm commented 8 months ago

can you give me the link to check it? in the link i have nothing changed, even though Lewis sent me screenshot of something else. this is the link i have:

https://good-swap-9ydt52ssf-gooddollarteam.vercel.app/#/claim

L03TJ3 commented 8 months ago

@SanaJamm https://dev.gooddapp.org

SanaJamm commented 8 months ago

Confirmed. thanks!

vldkhh commented 8 months ago

@Sana could you verify new designs on prod? for me it looks fine

SanaJamm commented 8 months ago

WhatsApp Image 2023-10-26 at 11 14 14

this is how i see it on my mobile..part of the side menu is hidden at the bottom

L03TJ3 commented 8 months ago

@SanaJamm please share model/device etc. for this stuff there is not one solution which works everywhere

SanaJamm commented 8 months ago

my mobile is iphone 13 pro max, if the only solution for this is to keep it like before (to be above the connect wallet) then i think it's better to restore it, because we cant risk having this part cut. sorry for the trouble

vldkhh commented 8 months ago

verified on prod. iPhone 13 Pro Max