GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

[Bug(ish)]: orbis/newsfeed component triggers extensive re-render #484

Closed L03TJ3 closed 7 months ago

L03TJ3 commented 8 months ago

How it should work The newsfeed is by default set to sync every hour to fetch/check updated items from orbis. if the items are fetched, they will locally be read from the dexie storage.

Bug Description Orbis initialization is triggered extensively. easily to check on the claim page and open logs

  1. this should be kept to a minimum, maybe should not happen at all?
  2. it can already be seen happening when running sdk-v2 story but not this often

To fix

L03TJ3 commented 8 months ago

fixed, moved context up the three here: https://github.com/GoodDollar/GoodProtocolUI/commit/f2b3f3a006f6c7665fbb1e3eb014202b66e24ab3

vldkhh commented 7 months ago

verified on prod