GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Bug: mainnet stakes not loading #490

Closed L03TJ3 closed 7 months ago

L03TJ3 commented 7 months ago

Bug Description There are two reports:

  1. mainnet stakes don't show the correct apy rates
  2. they don't load at all

Issue for the rates (and likely related to also not loading at all): https://api.compound.finance/api/v2/ctoken?addresses=0x5d3a536E4D6DbD6114cc1Ead35777bAB948E3643&network=mainnet

The api has been offline since 15th of april

Steps to Reproduce

  1. gooddapp.org/#/stakes
sirpy commented 7 months ago

@L03TJ3 i've added a new method to get compound DAI staking APY sdk/src/core/rest.ts compoundDaiStakingAPY notice that this is fixed for DAI, and it doesnt have the same interface as the old compoundStaking. We dont have any other compound pools so its fine for now. so just replace compoundStaking call

L03TJ3 commented 7 months ago

fixed here: https://github.com/GoodDollar/GoodProtocolUI/commit/6e069203b12cc23a3204556caa5e49285c1d389c and here: https://github.com/GoodDollar/GoodWeb3-Mono/commit/53ad039ff2082fb7e98a8f26b1a270038970bc55

L03TJ3 commented 7 months ago

@vldkhh could you verify they:

  1. loading
  2. social apy is set
  3. try a bunch of times, maybe with different chrome profiles? I sometimes get rpc requests errors and then none of the stakes are loading. (if you can reproduce this, then we need a new ticket for that)
sirpy commented 7 months ago

@patpedrosa @L03TJ3 maybe we can hide the APY since its 0 and not expected to change

vldkhh commented 7 months ago

verified on prod