GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Buy widget review #491

Closed sirpy closed 10 months ago

sirpy commented 10 months ago

Private Zenhub Image

L03TJ3 commented 10 months ago

@patpedrosa @SanaJamm

  1. can I expect a updated FAQ?
  2. form link, where to place? (just at the bottom of faq?)
L03TJ3 commented 10 months ago

calculation got fixed here: https://github.com/GoodDollar/GoodProtocolUI/commit/4541004fa1c548ff2a7f540247bc59d278f4b8b7

@patpedrosa @SanaJamm still awaiting confirmation on last comment

vldkhh commented 10 months ago

@L03TJ3 confirmed that calculation is fixed

Snag_44c18ec7.png

@patpedrosa @SanaJamm what about Lewis's last comment?

patpedrosa commented 10 months ago

@decentralauren Can you please do a copy review as you're native speaker?

decentralauren commented 10 months ago

@patpedrosa I'm happy to! What copy needs to be reviewed? And is this for accuracy, tone, all of the above?

patpedrosa commented 10 months ago

@decentralauren Hadar mentioned in his first message that the FAQ is too long and unformatted.

decentralauren commented 10 months ago

Note to self: To add more detail in FAQ:

https://docs.onramper.com/ Varies per payment provider Varies per country and jurisdiction What may not be supported (certain locations and payment types)

decentralauren commented 10 months ago

@patpedrosa mind reviewing my updated FAQs? Also running by comms for a quick check.

https://www.notion.so/gooddollar/Update-FAQ-content-on-Buy-G-page-b3351b6ff9eb45d28970087af1345d6d

L03TJ3 commented 10 months ago

@decentralauren @patpedrosa the current discussion is going to be continued in this ticket: https://github.com/GoodDollar/GoodProtocolUI/issues/502

(Can this be closed or not after release today)

vldkhh commented 10 months ago

verified on prod. continued here #502