GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

[Design QA] Buy G$ & Claim screen / Desktop #495

Closed SanaJamm closed 7 months ago

SanaJamm commented 7 months ago

Let's keep the right sections and left sections in same same ratio in all screens (every screen that have two parallel sections) I fixed it both in the claim and the buy G$ screens. and let's keep a 32px right padding in screens. right now the news feed is sticked to the right side of the screen.

Design:

Screen Shot 2023-11-28 at 13 38 49
vldkhh commented 7 months ago

@L03TJ3 components are overlapping each other on the claim G$ screen

Snag_44bd91e7.png

@SanaJamm (cannot tag her) @patpedrosa there is a lot of white space on the BuyG$ screen, I think we need a solution for it

Snag_44bf60cb.png
vldkhh commented 7 months ago

@L03TJ3 @SanaJamm need to centralize the post-claim screen. Also the news feed looks smaller as before

Snag_4ebe374b.png

And this is how the claim screen looks like on Pat's device

Snag_4ebf5128.png
L03TJ3 commented 7 months ago

@vldkhh newsfeed is the new size as requested. right container is fixed at 375px (both buy/claim) left container should fill up the rest of the page

@patpedrosa can you provide screen-size/resolution? or device/type? then I can verify on browserstack whats happening

L03TJ3 commented 7 months ago

@patpedrosa nvm, I think I replicated in brave browser. should be fixed now, can you verify this on dev.gooddapp.org ? (its being deployed now, should be up in 15 minutes or so)

L03TJ3 commented 7 months ago

Verified all is working, confirmed by both @patpedrosa @vldkhh @SanaJamm

vldkhh commented 7 months ago

verified on prod