GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Expose Wallet Balance in GoodDapp & Simple Dapp #498

Closed patpedrosa closed 8 months ago

patpedrosa commented 10 months ago

Currently MiniPay and GoodDapp mobile users can only see their cUSD / CELO balance (respectively) - which leads them to confusion after a claim, as their main balance doesn't change.

This issue is to implement GoodDollar wallet balance to the dApp (simple, mobile and desktop) at the header bar, and allow the user to tap / click to expand and see all GOOD-related tokens.

L03TJ3 commented 10 months ago

@patpedrosa Is this about the top-left price?

patpedrosa commented 9 months ago

@L03TJ3 We're putting this in the backlog for now.

decentralauren commented 9 months ago

Figma file https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=10159-4857&mode=design&t=sU6Df5VHiwqk2ncd-0

decentralauren commented 9 months ago

@L03TJ3 updated title - you're right it should just be displaying balance not conversion.

SanaJamm commented 9 months ago

this is the figma file for this card: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC?node-id=10159:4857&mode=design#658583658

to explain the animation of how this acts.. when pressing the wallet icon, the window slides down. it closes when pressing the wallet icon or anywhere on the screen. if the user presses on the menu button while the wallet balance is also open, then it closes and the other way around.

vldkhh commented 8 months ago

@L03TJ3 @patpedrosa @decentralauren verified on dev

Snag_7c5ca536.png
L03TJ3 commented 8 months ago

@decentralauren @patpedrosa @SanaJamm

Kindly do the qa review, this is the last item to be PR'd before release today

patpedrosa commented 8 months ago

top nav g$ balance is not center aligned with the icon. when i open the modal on my screen, it opens outside of my viewport.

Screen Shot 2024-01-10 at 11.43.24.png
SanaJamm commented 8 months ago

I'll add to Pat's comment.. not only that the balance is not centered with the icon. but everything in the top navbar doesn't seem center aligned. the space below the logo, balance and menu seems larger than the topper part

L03TJ3 commented 8 months ago

@SanaJamm

  1. noted
  2. We are talking just the mobile view not aligned right? desktop is fine?
L03TJ3 commented 8 months ago

@SanaJamm This should be it right? image

vldkhh commented 8 months ago

verified on prod