GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

Update Page Layout for GoodDapp (title & description) #519

Closed patpedrosa closed 7 months ago

patpedrosa commented 8 months ago

We want to add more context to GoodDapp so that users know how they are interacting with GoodDollar and get extra content such as faq, links, and videos.

We're proposing implementing a framework that uses existing components (headline, subhead, dropdowns) and styling (fonts, proportions) defined by Sana - with the purpose of making it easier to implement.

Figma: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=10459-3581&mode=design&t=OvORKDuXB2adTWob-0

The idea is that the main component will live in the "grey" area, while the right side will be populated with content.

We want to implement it first to the swap and the stake pages. If there's no copy on the dropdowns, they should not show.

SanaJamm commented 8 months ago

I made several breakpoints examples:

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC?node-id=10459:3581&mode=design#670123421

on my opinion the menu should open half width on tablets: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC?node-id=10459:3581&mode=design#670131937

drptiago commented 8 months ago

About events and tracking.

If we will add new menus in the left menu ( image below), lets follow the same pattern:

goto_claim
goto_swap
goto_bridge
goto_squid

Right now, all menus in production have the proper events. image

In the new "dropdowns" we can define a patter like: dropdown_page_content

Examples in the image below:

dropdown_swap_dropdowns1
dropdown_swap_video_guides
dropdown_swap_faq

image

L03TJ3 commented 7 months ago

@SanaJamm @patpedrosa should be reviewed on production

L03TJ3 commented 7 months ago

Ready for review on production @SanaJamm @patpedrosa

patpedrosa commented 7 months ago

It looks like there's an issue with the padding and the alignment of items. See dev vs design:

Screen Shot 2024-02-16 at 08.48.01.png Screen Shot 2024-02-16 at 08.48.54.png
decentralauren commented 7 months ago

@L03TJ3 - should we close this and start new tickets for any UI issues we find moving forward (padding etc)? cc @vldkhh what do you think?

L03TJ3 commented 7 months ago

To me this ticket was about the page-layout update and aligned with this the break-points for mobile/tablet/desktop which got fixed. I would say any additional ui stuff should be separate tickets yes

decentralauren commented 7 months ago

@L03TJ3 thanks - closing.