search

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

[GoodBridge]: Fee amounts are not applied correctly #554

Open L03TJ3 opened 2 months ago

L03TJ3 commented 2 months ago

Bug Description The fee amount shows 50% of what is actually withdrawn.

To look into:

  1. why is there a fee difference (in UI display) between dev wallet / dev gooddapp even though they interact with the same contract
  2. why is showing a 'to-receive-amount' of 998.50 on a 1000 transfer?

Steps to Reproduce

  1. Go to dev.gooddapp
  2. Click on microbridge
  3. connect wallet
  4. connect to fuse (celo has a bug in decimal conversion)
  5. fill in 1000
  6. see to receive amount
  7. execute
  8. see transaction on explorer for the actual amounts used

Expected Behavior The amount to receive should apply fees withdrawn correctly

decentralauren commented 3 weeks ago

@L03TJ3 this seems like something we should resolve before launching the MicroBridge - can you review?

L03TJ3 commented 3 weeks ago

@decentralauren should already be in progress, moved now