GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

New page for News Feed (move from Claim) #564

Closed decentralauren closed 1 month ago

decentralauren commented 4 months ago

Business Description

For usability and more clear access to each feature, we are separating out the New Feed from Claim in GoodDapp (were previously on the same page). They were previously on the same page because the MiniPay dapp allowed useres to access only the "Claim" page on GoodDapp, which is changing as users will now be able to access the menu and select GoodDapp functionality (including this News page).

Detailed Description of Functionality

Technical Implementation

*Outline the technical approach for building the feature. This section is typically filled out by the development team or can contain suggestions. (dev team: @johnsmith-gooddollar @sirpy @L03TJ3)

Design Reference

@sanajamm will add in comments below.

Acceptance Criteria

Specify criteria that will be used to determine if the feature meets the requirements and functions correctly.

Test Cases

Specify the happy path and unhappy path scenarios to test to verify the feature works as expected.

sirpy commented 4 months ago

The claim page is our best asset to show news. if anything i'd move the last TXs to a separate tab.

decentralauren commented 4 months ago

It is unlikely people see it now accessing the Claim page by mobile, with all of the other info on that page.

I prefer that we direct users first to the News feed (IE have News be "Home," not "Claim") then have them navigate to Claim in the nav.

I also like the idea of having an Acctivity tab that has all activity done in the dapp, however still think the News should be separated out from Claim.

@sirpy

SanaJamm commented 4 months ago

@decentralauren @L03TJ3

Mobile:

Screen Shot 2024-07-16 at 14 52 53

Desktop:

Screen Shot 2024-07-16 at 14 51 59

Figma: https://www.figma.com/design/ihw1PxBvLxacTHnN2aj4lC/3.-Product?node-id=19528-73612&t=ri63stIDIMgmBkWt-1

L03TJ3 commented 4 months ago

@decentralauren fyi: we already have a transaction history under account details btw:

image

L03TJ3 commented 2 months ago

added here: https://github.com/GoodDollar/GoodProtocolUI/commit/4b78fbe7d992436dd76b395c354763d529dd2847

sirpy commented 1 month ago

@L03TJ3 @decentralauren did we deploy already? isnt this similar to #567

L03TJ3 commented 1 month ago

@sirpy

  1. yes this is deployed
  2. no, the other one is about showing a single (latest) news feed item on the post-claim screen. but that has been added to the goodid PR already: https://github.com/GoodDollar/GoodWeb3-Mono/pull/128
decentralauren commented 1 month ago

@L03TJ3 why is this still open?

vldkhh commented 1 month ago

verified on prod