search

GoodDollar / GoodProtocolUI

UI for the GoodProtocol smart contracts
https://good-swap.vercel.app
GNU General Public License v3.0
7 stars 12 forks source link

(BUG) Staked G$ not showing on portfolio on Gooddapp #565

Closed decentralauren closed 3 months ago

decentralauren commented 4 months ago
  1. Reporting on slack first
    1. 2 users have reported this
    2. I also checked and did not see is staked G$ on is portfolio but he can see it on the explorer
    3. GoodDollar App version 2.42.0
  2. 0xFf00A683f7bD77665754A65F2B82fdEFc4371a50
Screenshot_20240719_004300_Chrome.jpg
L03TJ3 commented 4 months ago

@sirpy I am already on this and it seems like rpc issue (am in the middle of testing). I will keep you posted on status if not solved by tomorrow

L03TJ3 commented 4 months ago

a fix has been pushed here: https://github.com/GoodDollar/GoodWeb3-Mono/commit/c0cce300eb9280845d23442394db884dce650ce1

@sirpy Maybe you know a better way to handle it.

It seems to be getting confused by passed down providers and using the wrong one when trying to fetch mainnet data. I likely missed a place where a provider was passed down but I could not fully trace where it was.

Why I for now (as a hotfix) did a forced local mainnet provider for fetching mainnet data

decentralauren commented 4 months ago

@vldkhh are you able to test this in dev?

vldkhh commented 4 months ago

@decentralauren I still don't understand the issue. If this is correct - then we can push fixes to prod Snag_3f21ed

L03TJ3 commented 3 months ago

@vldkhh already in prod. If active stake shows up > working