GoodDollar / GoodServer

Backend to support the GoodDAPP
MIT License
13 stars 14 forks source link

Server should use GoodCFVerify to send sms verification #295

Closed sirpy closed 3 years ago

sirpy commented 3 years ago

Modify server to send SMS via worker and not directly using twilio so the logic for 3rd + 4th request is the same

on server

on worker

omerzam commented 3 years ago

@sirpy since I don't have a custom code when coming from the server using the programmable SMS is impossible I will add logic to skip this step when coming from the server and going straight to voice verification

omerzam commented 3 years ago

after consulting with @sirpy : generate the code in the worker and keep it in the KV store

iLystopad commented 3 years ago

@sirpy The user gets the verification code by SMS without issues (except #2939) after editing the Phone number on the Edit profile screen and after sign in/up with Auth0/Google/Facebook.

Checked on the QA 1.24.1-6 Device: Desktop / Windows 10 / Google Chrome 89.0.4389.90