GoodDollar / GoodServer

Backend to support the GoodDAPP
MIT License
13 stars 14 forks source link

(Chore) Rename "Zoom" to "FaceTec" #296

Closed serdiukov-o-nordwhale closed 3 years ago

serdiukov-o-nordwhale commented 3 years ago

Description

According to the FaceTec recommendations, all classes/methods/variables related to face verification having 'Zoom' in theirs names were renamed with FaceTec(faceTec) prefix

How Has This Been Tested?

After release we need to change names of the following env vars:

ZOOM_LICENSE_KEY => FACETEC_LICENSE_KEY ZOOM_SERVER_BASEURL => FACETEC_SERVER_BASEURL ZOOM_MINIMAL_MATCHLEVEL => FACETEC_MINIMAL_MATCHLEVEL

Also FACETEC_MINIMAL_MATCHLEVEL should be set to 10

Checklist:

sirpy commented 3 years ago

we dont need to rename

serdiukov-o-nordwhale commented 3 years ago

we dont need to rename

@sirpy They have renamed everything from "Zoom" to "FaceTec". This was marked as one of the main tips in the upgrade docs: https://dev.facetec.com/updating-v8-to-v9#tip-3 I suppose it's not just for fun. Most probably it's caused by the trademark violation (probably with Zoom Video Communications, Inc. ). I found in the old commits that API server was zoomlogin.com. So firstly (in v8) they renamed it to api.facetec.com, and now they've renamed everything. So better will be to follow that changes for a) do not correlate with Zoom conference b) keep both DApp and Server in a sync (as i've already renamed zoom -> facetec on the app side c) to avoid any lawsuits (to us or FaceTec) from Zoom Video Communications, Inc. Our code is open and any lawyer of that company could easily find that we're using FaceTec SDK but calling it 'Zoom' which could be represented as the trademark violation

serdiukov-o-nordwhale commented 3 years ago

Closing that PR by now but we’ll keep it so we could quickly apply if we’ll have law issues and will be required to rename everything