Closed sirpy closed 2 years ago
@johnsmith-gooddollar
@johnsmith-gooddollar that retry commit is pretty big, did you test things?
@johnsmith-gooddollar examine the 404 errors and trace why they happen and suggest fix
@johnsmith-gooddollar examine the 404 errors and trace why they happen and suggest fix
@sirpy
I've already examined Those errors are ok they are part of our logic (see my comment above). So no fix is needed.
To determine if some email exists/users we're doing call get by email If it fails with 404 - that means no email exists/email not used
I've linked exact place in the code containing this logic
Logging comes from crm api class which logs any success/failed intake response
@johnsmith-gooddollar what about the refactor you did... did you verify things are working? can you push it to production?
@johnsmith-gooddollar what about the refactor you did... did you verify things are working? can you push it to production?
@sirpy
a) it was tested on QA, everything is fine b) i've just added unit test for retry case, found one issue happening after retry, fixed it, pushed to master and staging https://github.com/GoodDollar/GoodServer/commit/c3f4cb94cbcfef6e2ba44dea57ffe93871ff7db2
Now we could push to PROD (with the wallet release)
Description
Looking at the logs (regex /OnGage error/), we have two repeating errors
{"url":"contacts/by_email/rizkypinong93%40gmail.com"}]}
Todo