email verification broken after mongodb upgrade

GoodDollar / GoodServer

Backend to support the GoodDAPP

MIT License

13 stars 12 forks source link

email verification broken after mongodb upgrade #401

Closed sirpy closed 1 year ago

sirpy commented 1 year ago

email verificaiton for new users seems to be broken. it looks like the "otp" field that should temporarily hold the email address is no longer working as expected

it contains a value of {_id:<number>} instead of {email:<string>}
This points that mongodb is saving the otp field as a separate document.
Also the schema for the OTP field seems old/incorrect could this have some effect on this?
Was new user signup tested??

johnsmith-gooddollar commented 1 year ago

@sirpy yes I've asked @vldkhh to test everything related to profiles (signing / signup different methods, updating feed, updating profile etc)

johnsmith-gooddollar commented 1 year ago

@vldkhh Need to re-check it at QA & PROD.

SMS pwdlress signup should work now.
An OTP code should be sent after you enter email
Code validation form should be submitted without errors
registration should finish successfully

vldkhh commented 1 year ago

@johnsmith-gooddollar verified on PROD, works without errors