GoodDollar / GoodServer

Backend to support the GoodDAPP
MIT License
13 stars 12 forks source link

Bug: delete fv-id fails to recover publickey #437

Closed L03TJ3 closed 9 months ago

L03TJ3 commented 10 months ago

Description

When attempting to delete face-id through gooddapp, the request to auth/fv2 fails on 'Recovery param is more then 2 bits'

Potential causes:

  1. too long sign message?
  2. really old packages (web3-eth-accounts + eth-lib).. readme for eth-lib also says it should no longer be used

Steps to reproduce

  1. go to dev.gooddapp.org
  2. connect a wallet and whitelist
  3. after whitelist success go to GoodID page (from sidebar)
  4. sign message to show face-id
  5. click on X to delete
  6. sign message and watch network console

Which network did you use?

Celo

Additional context-

image

L03TJ3 commented 9 months ago

This was caused by supplying only sliced signature (from sdk-v2 delete method) where the full signature was needed. So closing this