GoodDollar / GoodServer

Backend to support the GoodDAPP
MIT License
13 stars 14 forks source link

(Chore) Prepare apps to MongoDB 7 :: GoodServer #452

Closed johnsmith-gooddollar closed 9 months ago

johnsmith-gooddollar commented 9 months ago

Description

About #443

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

johnsmith-gooddollar commented 9 months ago
  • dont change logic of isdupuserdata
  • fix failing tests

the logic was wrong. if we had email in the user record been passed, phone was ignored. the corresponding unit test was failing

johnsmith-gooddollar commented 9 months ago

tests fixed

sirpy commented 9 months ago

@johnsmith-gooddollar the isdup logic expects only either mobile or email not both. please restore the way it was. if the test needs to be adapted change it, but do not change the logic

johnsmith-gooddollar commented 9 months ago

@sirpy done