netlify[bot]
commented
5 months ago Deploy Preview for goodeworkers ready!
| Name | Link |
|---|---|
| Latest commit | a251db2fc184c0b3ba81eb96e8a516c98059185f |
| Latest deploy log | https://app.netlify.com/sites/goodeworkers/deploys/660e727012b3dc0008bab7c1 |
| Deploy Preview | https://deploy-preview-25--goodeworkers.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
jc3lee
Summary of changes:
typescript, @types/node, @types/react, @types/react-domtsconfig.jsonfollowing the gatsby minimal ts examplegatsby-browser.js&gatsby-config.jstogatsby-browser.ts&gatsby-config.tsglobals.d.ts. It's a declaration of types file to handle imports (svg, images, etc) following the create react app exampleAnd with that, typescript has been successfully integrated 😃.
That took 10% of the time, the remaining 90% was on figuring out how to add eslint typescript. The hardest part was making eslint work on react js, jsx files while using typescript linting only on ts and tsx files. It's my first time setting eslint if you've found issues or have suggestions, I'm all ears 🙉. I've annoted the changes but please tell me if you have any questions. Here are the edits I did on eslintrc:
"plugin:@typescript-eslint/recommended"to"extends""parser": "@typescript-eslint/parser""@typescript-eslint"to"plugins""react/prop-types": "off"and"react/require-default-props": "off",since we can handle type check with ts"plugin:import/errors", "plugin:import/warnings"to"extends""import/resolver"to"settings""import/extensions"to"rules""react/jsx-filename-extension"to"rules"And with that, we've got linting on both javascript and typescript files!