search

GoodHive / app

https://goodhive.vercel.app
0 stars 4 forks source link

feat: homepage redesign completed #131

Closed sabbirrifat closed 8 months ago

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 6:08pm
n1c01a5 commented 8 months ago

@sabbirrifat the page looks very good.

But we use Tailwind instead of SASS. It's not good to mix 2 css pre-compilers.

You can convert SASS to Tailwind easily with ChatGPT.

n1c01a5 commented 8 months ago

@sabbirrifat can you give some details in the description of the PR ?

n1c01a5 commented 8 months ago

Some background buttons are quite transparents. Can you set a solid color in background ?

sabbirrifat commented 8 months ago

@sabbirrifat can you give some details in the description of the PR ?

okay will do

n1c01a5 commented 8 months ago

@sabbirrifat can you fix the error build : Module not found: Can't resolve './hero' ?

sabbirrifat commented 8 months ago

@n1c01a5 Strange, how come it's not changed in the remote branch when I already have that change in my local branch. And that's the reason deployment failed whereas local deployment is working as fine. I can't even change and commit which is already changed. Lemme push 2 new commits so I can change the naming

n1c01a5 commented 8 months ago

@sabbirrifat did you try to push the code remotly ?

sabbirrifat commented 8 months ago

@sabbirrifat did you try to push the code remotly ?

Yeah I was checking the github issues then I see that its a common issue with git when you just change the case of a filename instead of changing to a different name. here it is: https://github.com/isaacs/github/issues/1520

sabbirrifat commented 8 months ago

@n1c01a5 updated!