GoodbyteCo / Letterboxd-Watchlist-Picker

A simple website that gives you a random film off your Letterboxd watchlist (or any list).
https://watchlistpicker.com/
53 stars 3 forks source link

add lengthFilter #79

Closed HoloPollock closed 3 years ago

HoloPollock commented 3 years ago

add filter for shorts or features set to 80 Min as feature

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goodbyte/watchlist-picker/GZMmtmSFeKB1TjwhargqRtirQh5b
✅ Preview: https://watchlist-picker-git-add-length-filter-goodbyte.vercel.app

HoloPollock commented 3 years ago

only backend for now

HoloPollock commented 3 years ago

I broke actor I have to fix that to :(

HoloPollock commented 3 years ago

also if anyone wants to do the front end go ahead

HoloPollock commented 3 years ago

No one merge yet I wanna do testing cause I change how scraping works

HoloPollock commented 3 years ago

the speed slowed down with new changed I want to see if I can fix before merging

HoloPollock commented 3 years ago

I cheated and increased the memory and it worked

HoloPollock commented 3 years ago

still wanna do some more tests

qjack001 commented 3 years ago

Could I give you the options in a comma-seperated ignore param? Like: /?users=qjack&ignore=unreleased,shorts,feature&iintersect=true? Ignore unreleased films if unreleased is present, ignore short films if shorts is present, ignore feature-length if feature is present.

HoloPollock commented 3 years ago

Could I give you the options in a comma-seperated ignore param? Like: /?users=qjack&ignore=unreleased,shorts,feature&iintersect=true? Ignore unreleased films if unreleased is present, ignore short films if shorts is present, ignore feature-length if feature is present.

Yah that should work I can make that happen

qjack001 commented 3 years ago

Could I give you the options in a comma-seperated ignore param? Like: /?users=qjack&ignore=unreleased,shorts,feature&iintersect=true? Ignore unreleased films if unreleased is present, ignore short films if shorts is present, ignore feature-length if feature is present.

Yah that should work I can make that happen

yay

HoloPollock commented 3 years ago

so its done and works now I do think we may want to merge this in to the UI branch to test it works with ignore=unreleased,shorts,feature it should I tested with postman but still should test integration @qjack001

HoloPollock commented 3 years ago

also feel free to look at code for stupid things I did

HoloPollock commented 3 years ago

hey so I know why its slower the new page I'm loading is way bigger so it makes it way slower to do may not be worth

HoloPollock commented 3 years ago

I dont know another way to get the time though

HoloPollock commented 3 years ago

its. difference between loading this site and the full detail page ex this

HoloPollock commented 3 years ago

lol letterbox please give me API

HoloPollock commented 3 years ago

the only thing I can think of to keep this is only load the page when the check boxes are checked

qjack001 commented 3 years ago

the only thing I can think of to keep this is only load the page when the check boxes are checked

Only use the heavier page if the ignore parameter was given shorts or feature, yes.

qjack001 commented 3 years ago

so its done and works now I do think we may want to merge this in to the UI branch to test it works with ignore=unreleased,shorts,feature it should I tested with postman but still should test integration @qjack001

Once you make the change above, I would just merge into main. It should have no noticeable effect on the site (as it is now). My PR should get the update too, since I believe it uses the prod endpoint.

qjack001 commented 3 years ago

poke

HoloPollock commented 3 years ago

@qjack001 should be good to merge pls check

HoloPollock commented 3 years ago

also closes #69