search

GoodbyteCo / Letterboxd-Watchlist-Picker

A simple website that gives you a random film off your Letterboxd watchlist (or any list).
https://watchlistpicker.com/
53 stars 3 forks source link

Refactor frontend #80

Closed qjack001 closed 3 years ago

qjack001 commented 3 years ago

I'm going to finally do it. I'll try and use the new advanced-search features as a motivator to finish the refactor first.

This PR is a work in progress, I'll update it as I go along, so you can review it component-by-component rather than all at once (feel free to join in, if you want). Closes #65

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goodbyte/watchlist-picker/2iWwuqBp54QY53vWi4hUxhWMB8tF
✅ Preview: https://watchlist-picker-git-refactor-goodbyte.vercel.app

qjack001 commented 3 years ago

Basically, all the logic has been moved into App.vue, which also handles high level layout and styling (colour schemes, etc). Each component contains its own styling, and as little logic as nessesary (i.e. the SearchBar component doesnt actually do the search, it just handles the input). Still to-do (but in a future PR): rethink how the footer works, refactor the darkmode component, and re-check accessibility.

One other thing: I turned-off the ignore url-param. I have an idea for how it'll work with the short-film/feature-length options when we get there.

qjack001 commented 3 years ago

Ok I lied, I did the footer and darkmode refactors. Now closes #83

HoloPollock commented 3 years ago

one day you should teach me how emits work