search

GoodbyteCo / Letterboxd-Watchlist-Picker

A simple website that gives you a random film off your Letterboxd watchlist (or any list).
https://watchlistpicker.com/
53 stars 3 forks source link

Implement film length options frontend #84

Closed qjack001 closed 3 years ago

qjack001 commented 3 years ago

UI portion of #78. Closes #82. Dependant on merge of #79 for logic and #80 for current codebase. Also closes #81.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goodbyte/watchlist-picker/D7pnrLjdfEwVXJibHgmU2YGpwx8w
✅ Preview: https://watchlist-picker-git-frontend-film-length-goodbyte.vercel.app

qjack001 commented 3 years ago

Ah sorry, didn't realize the diff would be huge if I based it off the refactor. Really the only changes are in App.vue's logic for getting the url params, setting url params, building api endpoint, and in AdvancedOptions.vue (obviously).

HoloPollock commented 3 years ago

can you cancel this and just add it after merge of refactor

HoloPollock commented 3 years ago

I feel like will cause whacky things on merge

HoloPollock commented 3 years ago

oh lol I see your right it isnt binary of short or feature I though you would have to one or other lol

HoloPollock commented 3 years ago

I will fix on my side

qjack001 commented 3 years ago

I will fix on my side

Lol, just added a comment on your origional PR about it