search

GoodforGod / java-etherscan-api

🔗 Polished Java library for EtherScan.io API
https://etherscan.io
MIT License
58 stars 47 forks source link

Changed traceId in TxInternal from long to String #17

Closed guggio closed 2 years ago

guggio commented 2 years ago

Great Java implementation for the etherscan api! While fetching internal transaction data, I ran into a ParseException because of the traceId value of "1_0". In my case it was a refund from a uniswap trade.

You can check it yourself with address 0x82c1174618133b1a320106aa197d0e8ee7e36be4 (random address that interacted with uniswap and has non numeric traceIds for some of its internal transactions.

GoodforGod commented 2 years ago

Thanks for your PR !

I will make another getter for traceId to retrieve it as String, can't change existing one from long -> string cause this will break API, but I will keep that in mind in 2.0.0 version, thanks!