Wrong code in getRequestUsingOffset method of AccountAPIProvider

GoodforGod / java-etherscan-api

🔗 Polished Java library for EtherScan.io API

https://etherscan.io

MIT License

58 stars 47 forks source link

Wrong code in getRequestUsingOffset method of AccountAPIProvider #31

Open maxmmin opened 1 week ago

maxmmin commented 1 week ago

It has wrong logic. Etherscan allows fetching only 10k records. So paging with 10k-size page can't be implemented. And you didn't even make that method protected so i can't override it to use.

maxmmin commented 1 week ago

Haha, and BasicProvider is package-protected. I can't do nothing! Thank you so much!!!