search

GoodforGod / java-etherscan-api

🔗 Polished Java library for EtherScan.io API
https://etherscan.io
MIT License
58 stars 47 forks source link

Better connection exception reporting and small changes #6

Closed iSnow closed 3 years ago

iSnow commented 3 years ago

Hi, I added

Also fixed the Travis link on the README.md

codecov-commenter commented 3 years ago

Codecov Report

Merging #6 into master will decrease coverage by 20.57%. The diff coverage is 24.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage   79.25%   58.67%   -20.58%     
===========================================
  Files          71       72        +1     
  Lines         988     1014       +26     
  Branches      229      237        +8     
===========================================
- Hits          783      595      -188     
- Misses         67      326      +259     
+ Partials      138       93       -45
Impacted Files Coverage Δ
...va/io/api/etherscan/error/ConnectionException.java 50.00% <0.00%> (-50.00%) :arrow_down:
...ava/io/api/etherscan/error/RateLimitException.java 0.00% <0.00%> (ø)
...a/io/api/etherscan/executor/impl/HttpExecutor.java 71.42% <0.00%> (-8.88%) :arrow_down:
src/main/java/io/api/etherscan/model/Log.java 4.16% <0.00%> (-48.22%) :arrow_down:
...pi/etherscan/model/query/impl/LogQueryBuilder.java 91.17% <0.00%> (-2.77%) :arrow_down:
...java/io/api/etherscan/core/impl/BasicProvider.java 76.66% <50.00%> (-4.29%) :arrow_down:
...in/java/io/api/etherscan/error/ParseException.java 75.00% <66.66%> (+75.00%) :arrow_up:
src/main/java/io/api/etherscan/model/Supply.java 0.00% <0.00%> (-100.00%) :arrow_down:
src/main/java/io/api/etherscan/model/TxToken.java 0.00% <0.00%> (-100.00%) :arrow_down:
...va/io/api/etherscan/error/ApiTimeoutException.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00cff5f...f7bb00c. Read the comment docs.

GoodforGod commented 3 years ago

Hello and thanks for PR and improvements!

GoodforGod commented 3 years ago

It looks easier for me to merge and change all myself.

GoodforGod commented 3 years ago

Partly merged via cherry pick