GoodgameStudios / RobotlegsJS-Macrobot

MOVED: This project has moved to https://github.com/RobotlegsJS/RobotlegsJS-Macrobot
MIT License
0 stars 0 forks source link

An in-range update of robotlegs is breaking the build 🚨 #21

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 1.0.0 of robotlegs just got published.

Branch Build failing 🚨
Dependency robotlegs
Current Version 1.0.0-alpha.14
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

robotlegs is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/GoodgameStudios/RobotlegsJS-Macrobot/builds/257016279?utm_source=github_status&utm_medium=notification)

Release Notes 1.0.0

Breaking changes

There is a breaking change in this release related to the latest version of InversifyJS.

The InversifyJS, from version 3.0.0, supports natively hierarchical levels between injectors. The class that plays the role of the injector was renamed from Kernel to Container, and a createChild method was added. The native support of a parent / child relationship between containers brings the InversifyJS API more closer to the SwiftSuspenders API and removes the necessity of hard coded implementation on this port of the original robotlegs-framework from AS3 to TypeScript/JS.

To avoid confusion between the interfaces.Container API and the IInjector API, it was decided to use the API provided by the interfaces.Container class directly, and all auxiliar methods added to the IInjector was removed.

Removed methods that should be replaced

The hasMapping, satisfies and teardown methods was removed and should be replaced by the usage of:

  • isBound instead of hasMapping
  • isBound instead of satisfies
  • unbindAll instead of teardown

Removed method that was turned into a auxiliary method

The instantiateUnmapped method was removed and now is a auxiliar method that can be imported from the robotlegs context:

import { instantiateUnmapped } from "robotlegs";

function applyHooks(hooks: any[], injector?: IInjector): void {
    for (let i = 0; i < hooks.length; i++) {
        let hook: any = hooks[i];

        if ((typeof (hook) === "function") && (hook.prototype.hook === undefined)) {
            (<Function>hook)();
            continue;
        }

        if ((typeof (hook) === "function") && (hook.prototype.hook !== undefined)) {
            hook = injector ? instantiateUnmapped(injector, hook) : new hook();
        }

        hook.hook();
    }
}

Method that have a new return type

The createChild method is directly provided by the interfaces.Container interface. Instead of return a IInjector, this method will return a interfaces.Container instance.

Commits

The new version differs by 56 commits.

  • 1db8974 update package version to 1.0.0
  • 913c286 chore(package): update ts-node to version 3.2.2
  • 6f37d1b Merge pull request #64 from GoodgameStudios/ieventmap-unmaplistener
  • 0238197 Merge pull request #82 from GoodgameStudios/upgrade-dependencies
  • 0d0a720 chore(package): update webpack-dev-server to version 2.6.1
  • a60ab31 chore(package): update ts-node to version 3.2.1
  • d517f14 Merge pull request #81 from GoodgameStudios/upgrade-inversify
  • 192c108 clean-up IInjector and closes #28
  • 3797ba2 chore(package): update reflect-metadata to version 0.1.10
  • 8690f2a chore(package): update inversify to version 4.3.0
  • d6ef665 remove teardown method from IInjector and use unbindAll method instead
  • d9d13ed remove satisfies method from IInjector and use isBound method instead
  • 9996b06 remove hasMapping method from IInjector and use isBound method instead
  • beda712 disable no-inferrable-types rule on tslint file
  • e75fed6 remove instantiateUnmapped method from IInjector and add it as a static method

There are 56 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 1.0.0-alpha.14 your tests are passing again. Downgrade this dependency 📌.

tiagoschenkel commented 7 years ago

robotlegs updated to version 1.0.0