dpToPx converter in CarouselPicker.java class

GoodieBag / CarouselPicker

A Carousel picker library for android which supports both text and icons . :sparkles:

MIT License

708 stars 101 forks source link

dpToPx converter in CarouselPicker.java class #18

Open davidhowe opened 5 years ago

davidhowe commented 5 years ago

Consider changing your dpToPx conversion to Math.round(dp * (displayMetrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT)). You are using displayMetrics.xdpi inplace of the device true densityDpi. This had big consequences for us across different devices such as Samsung S9+

thirstycoda commented 4 years ago

Hopefully this is addressed under pull request #29