Goodman-lab / DP5

Python workflow for DP5 and DP4 analysis of organic molecules
Other
173 stars 99 forks source link

could you tell me more details about what type of folders can be added? #20

Closed kkBecky closed 4 years ago

kkBecky commented 4 years ago

I download some folders from the link https://www.repository.cam.ac.uk/handle/1810/303161 you provide, but only the sdf format can be added in"structure", no other files can be added in "NMR", I am wondering that what kind of NMR data can be added, usually I use Mestrenova to get the NMR data and output data to Word. thank you

KristapsE commented 4 years ago

Structure expects you add your structure candidates - what structures do you want DP4 to distinguish between?

NMR field expects you to add NMR data - either NMR descriptions in the format expected by the DP4, or in the form of a Bruker folder, containing raw carbon and proton NMR data. Examples of both are in each of the folders in the Cambridge repository dataset.

kkBecky commented 4 years ago

First , I want to confirm the structure.I put my data in the Spectral Database to analyze. I only got a cerebroside-type compound with a similarity rate of 73%. I want to know whether the structure of the compound can be determined by DP4.

When I try to use your software, I downloaded the KE1 file from the link Cambridge repository dataset, added the sdf file⁨ KE1⁩/Opt_E⁩/KE1_3.sdf & KE1⁩/Opt_E⁩/KE1_4.sdf (picture1) in the "structure", and no file could be added in the "NMR "(picture2), so I had to add the carbon and proton folders KE1/Opt_E/NMR_folder/Carbon & KE1/Opt_E/NMR_folder/Proton. After adding the output folder and click to "calculate", the program reports an error (picture3) This is the problem I met, I hope you can give me some suggestions, thank you!

picture1 picture2 picture3
KristapsE commented 4 years ago

Do you have MacroModel installed? The script seems to tell you that you don't have a molecular mechanics software installed or that it doesn't know where it is installed. DP4-AI requires either TINKER or MacroModel to function properly on new compounds.

The GUI should still give you an answer for already calculated compounds, so maybe Alex will chip in about why it is still looking for MacroModel on our data.

kkBecky commented 4 years ago

Thanks for your reply! I will download the MacroModel to see if it works!!

KristapsE commented 4 years ago

MacroModel is a commercial package, if you don't have access to a license already, it would be quite expensive to acquire it. For running new analysis, open-source TINKER may be a financially more realistic option. Running DP4-AI on existing computational data shouldn't require any additional software - we are looking into why this is not the case.

kkBecky commented 4 years ago

Thank you for your reminding! I did have trouble installing the MacroModel, and I am now trying to install Tinker, I have limited knowledge in computer chemistry, so it will take some time. Thank you for your answer! I will try if DP4 works after installing Tinker!!

kkBecky commented 4 years ago

I have already installed Tinker, but still reports an error(picture) thank you!!

picture 2020-05-06 20 39 48
HowarthA commented 4 years ago

Hi, a little note about passing the NMR data. At the moment DP4-AI is expecting you to give it a single folder containing the carbon and proton data as subfolders, in the case of KE3 it wants the whole "NMR_folder". I wonder whether giving it the proton and carbon data separately has lead to some additional files being generated with odd file extensions, this might be why it no longer likes KE3_4.sdf. Try starting with a new copy of the KE3 folder. Something else that may be causing it to trip up is requesting diastereomer generation whilst passing multiple structures, try deselecting this toggle switch. Hope this helps.

kkBecky commented 4 years ago

Hi, I tried again according to your suggestion. No matter if I add one or more sdf files to the “structure”, the same error still occurs(picture). I am wondering if it is because the full directory of the JB2_4.sdf can not be added in your software. Thank you!!

picture1 2020-05-06 23 12 59 picture2 2020-05-06 23 18 57
KristapsE commented 4 years ago

Did you launch the GUI from the folder where your data is, or from the DP4-AI folder?

The command should look something like this:

Becky:/path/to/JB2 beckyke$ python /path/to/DP4-AI/PyDP4_GUI.py

We are working on removing this quirk from the software.

youngbee12 commented 4 years ago

I don't know why this happens 图片

KristapsE commented 4 years ago

@youngbee12 this looks like a separate issue - would you mind opening a new issue? Thanks.

kkBecky commented 4 years ago

I launched the GUI from the folder where my data was before. Should I remove the data to the DP4-AI folder? I just try it but still the same error occurs thanks

picture 2020-05-07 18 53 44
KristapsE commented 4 years ago

Thank you for your patience! I am working on this issue right now, there should be an improved version tomorrow morning. Yes, moving the data to the DP4-AI folder should work, but it's not very user friendly, so I am working on a fix.

HowarthA commented 4 years ago

Hi, just to chip in. We are very close to an improved file input system so all of these problems will be fixed very soon. If you download the JB2 folder from the repository, you will want to change to the "MM" subdirectory within this folder before running the GUI i.e first run the command "cd /your path here/JB2/MM" then "python /path to pydp4/PyDP4_GUI.py". Next add JB2_4.sdf to the structure dialogue and the whole "NMR_folder" to the NMR dialogue. Click the "NMR assignment" checkbox and then make sure to uncheck the generate diastereomers checkbox finally hit Calculate. Hopefully this will get you up and running before trying out Tinker. Hope this helps!

kkBecky commented 4 years ago

Hi, I used your latest script and follow your instructions to run the calculation, but still the error occurs.

屏幕快照 2020-05-08 09 25 03
renzilin commented 4 years ago

Dear Authors, I thouht that I have the same problems on my ubuntu 16.04. I used conda & pip to create the enviroment. And as your instructions, I cd to the JB2 folder and started the GUI script. image

And then I followed your instruction to choose the file JB2_4.sdf and folders NMR_folder. Press Calculate. image

Here's the return with error. image

Thank your for your help.

KristapsE commented 4 years ago

Hi @kkBecky and @renzilin! We have just pushed a new update which significantly improves the path logic behind the GUI, so please download the latest source code and copy it over and let us know how it goes! Just as a reminder - in the Add structure please add all of the diastereomers in the folder (JB1_1.sdf, JB12.sdf etc, but not JB.sdf), in the NMR folder add the corresponding NMR data folder and in the output folder add the whole top level folder containing both the sdf files and the NMR data. Please don't use Generate diastereomers option if you provide more than one structure.

kkBecky commented 4 years ago

Hi, thanks for your help but there is still something wrong. I used your latest script just then, and follow your instructions. Add Downloads/JB2/MM/JB2_2.sdf and Downloads/JB2/MM/JB2_4.sdf. in "structure", add Downloads/JB2/MM/NMR_folder in "NMR", add add Downloads/JB2/MM in "output" (picture1), but there is still error occurs(picture2) thank you!!

picture1 2020-05-08 22 12 15 picture2 2020-05-08 22 13 05
KristapsE commented 4 years ago

When trying to run our data, you should select MacroModel, not Tinker, as we used MacroModel for our workflows.

For your own process, you will need to select TINKER for Molecular Mechanics. And we will need to add options in the GUI for using NWChem. Also there will be a need for some modifications in the script specifically for your situation that you will need to make to ensure script knows where your TINKER and NWChem lives.

renzilin commented 4 years ago

When trying to run our data, you should select MacroModel, not Tinker, as we used MacroModel for our workflows.

For your own process, you will need to select TINKER for Molecular Mechanics. And we will need to add options in the GUI for using NWChem. Also there will be a need for some modifications in the script specifically for your situation that you will need to make to ensure script knows where your TINKER and NWChem lives.

Okay, thanks for your quick reply. I re-read your intro, I think the tinker and NWChem is both need, I'll try it with our own data.

Thank you.

KristapsE commented 4 years ago

Hi @renzilin and @kkBecky ! I had a chance to do some coding today and implemented a separate config file - settings.cfg. This meant as an easier way to let DP4-AI know where to find the molecular mechanics (TINKER or MacroModel) and the DFT (Gaussian or NWChem) packages. A sample settings.cfg file is provided in the latest update - feel free to download the latest version, test it and let us know how it does!

renzilin commented 4 years ago

Hi @renzilin and @kkBecky ! I had a chance to do some coding today and implemented a separate config file - settings.cfg. This meant as an easier way to let DP4-AI know where to find the molecular mechanics (TINKER or MacroModel) and the DFT (Gaussian or NWChem) packages. A sample settings.cfg file is provided in the latest update - feel free to download the latest version, test it and let us know how it does!

Hi @KristapsE ! Could you please explain what is the sdf2tinkerxyz? It can't work when we used tinker to do analysis. The same mistake: Annotation 2020-05-10 000210

KristapsE commented 4 years ago

It's a utility that converts from sdf to TINKER custom xyz format. There are binaries for all three major platforms available from this website, as well as the source code.

http://sdf2xyz2sdf.sourceforge.net/?Description:sdf2tinkerxyz

KristapsE commented 4 years ago

I think this particular issue about folders in the GUI have been solved, so I will close this now.