search

Goodwy / Dialer

GNU General Public License v3.0
64 stars 15 forks source link

Big stutter while the top part fades (affects all Right apps) #42

Open GaucovyAero opened 3 months ago

GaucovyAero commented 3 months ago

This is a duplicate/repost of https://github.com/Goodwy/Gallery/issues/9, as I just figured out it affects all Right apps. It is very noticeable on 120Hz.

Device: Xiaomi Poco F3 8/256G (Snapdragon 870) App version: 5.2.3 (affects all Right apps)

When this part fades from black to blue, the whole app stutters quite a bit:

Screenshot_20240821-215552_Contacts

Goodwy commented 3 months ago

Can you explain more, is there some sort of uneven color change or something? Can you send me a screen recording of the problem?

GaucovyAero commented 3 months ago

Can you explain more, is there some sort of uneven color change or something?

No, just huge FPS drops and stuttering.

I'm using Gallery in the video in order not to show personal stuff. In the top right corner you can see the FPS. The Phone app runs at constant 120fps, but when the top part fades, it goes down to 80-90fps with stutters.

https://github.com/user-attachments/assets/2e703603-ee95-49a0-9ac1-216cae4df70d

Goodwy commented 3 months ago

In the phone application you can enable that the tab navigation would be in the top, then the color of the top panel will not change. Can you check the FPS drop with this setting?

GaucovyAero commented 3 months ago

In the phone application you can enable that the tab navigation would be in the top, then the color of the top panel will not change. Can you check the FPS drop with this setting?

FPS are locked 120, no drops at all

GaucovyAero commented 3 months ago

this is not a fix, as the issue is still present in Gallery and Messages no matter what

Goodwy commented 3 months ago

Has the latest version of the Dialer app not gotten any better?

GaucovyAero commented 3 months ago

Has the latest version of the Dialer app not gotten any better?

it's the same or worse, when i open the app the first time, i get drops down to 30fps (huge), and when i repeatedly do the same thing i'm dropping to about 90fps, version is 5.2.6

GaucovyAero commented 3 months ago

try checking the fade implementation in the Glimpse gallery, it works fine on there

https://github.com/lineage-next/android_packages_apps_Glimpse

https://github.com/user-attachments/assets/3d2cb7a4-86b0-46ca-bbfc-30dac43804f7

Goodwy commented 3 months ago

Check the Dialer application version 5.2.7. If it doesn't help, we can make a setting to disable this feature.

GaucovyAero commented 3 months ago

nope, still very laggy there