GooeyAI / gooey-server

The core orchestration logic behind Gooey.AI
https://gooey.ai
Other
9 stars 2 forks source link

support facebook video url download via yt-dlp #469

Closed devxpy closed 2 weeks ago

devxpy commented 1 month ago

Q/A checklist


Executed in 1.15 secs fish external usr time 2.22 secs 86.00 micros 2.22 secs sys time 0.72 secs 613.00 micros 0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:
```python
def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

devxpy commented 1 month ago

doesnt work yet because fb doesnt do --format bestaudio

nikochiko commented 2 weeks ago

@devxpy - fixed with --format bestaudio/best - this will automatically fallback to some video format when bestaudio isn't available. weirdly, when --format ... is not provided, yt-dlp adds an extension like .mp4 at the end of the output filename.

what do you think about the codeql suggestions on this PR?

devxpy commented 2 weeks ago

lgtm