Closed nikochiko closed 4 hours ago
@devxpy this is ready for review.
Fix for the failing test was to set validate_constraints=False
in Workspace.create_with_owner
. get_or_create_from_user
was handling the IntegrityError
in case another transaction committed the unique workspace concurrently. Without this flag, that error was being thrown as a ValidationError
. Weird part was that I couldn't repro it locally.
lgtm
Changes
NOT in scope
Q/A checklist
To measure import time for a specific library:
Executed in 1.15 secs fish external usr time 2.22 secs 86.00 micros 2.22 secs sys time 0.72 secs 613.00 micros 0.72 secs
Legal Boilerplate
Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.