GooeyAI / gooey-server

The core orchestration logic behind Gooey.AI
https://gooey.ai
Other
9 stars 2 forks source link

Add workspaces to published runs #490

Closed nikochiko closed 4 hours ago

nikochiko commented 1 week ago

Changes

NOT in scope

Q/A checklist


Executed in 1.15 secs fish external usr time 2.22 secs 86.00 micros 2.22 secs sys time 0.72 secs 613.00 micros 0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:
```python
def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

nikochiko commented 3 days ago

@devxpy this is ready for review.

Fix for the failing test was to set validate_constraints=False in Workspace.create_with_owner. get_or_create_from_user was handling the IntegrityError in case another transaction committed the unique workspace concurrently. Without this flag, that error was being thrown as a ValidationError. Weird part was that I couldn't repro it locally.

devxpy commented 5 hours ago

lgtm